Deprecate gx1 CORE forcing option#643
Merged
Merged
Conversation
eclare108213
approved these changes
Oct 13, 2021
Contributor
eclare108213
left a comment
eclare108213
left a comment
There was a problem hiding this comment.
This looks fine to me too. The forcing wiki page likely will need to be updated -- could include a note that the LYq option / CORE forcing was deprecated -- and I can also add that information to the zenodo metadata.
Contributor
|
Thanks for doing this Tony! |
Contributor
Author
|
I have updated the forcing wiki page to indicate that the gx1 core forcing was deprecated on 10/2021 and is available up to CICE6.3.0. At present, the data is still available on zenodo. We should probably remove it the next time we create a gx1 tar file. Users of older CICE versions can download earlier versions of the input data. |
phil-blain
added a commit
to phil-blain/CICE
that referenced
this pull request
Nov 29, 2021
This reverts commit 9f72e87.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Deprecate gx1 CORE forcing option
apcraig
Ran the quick suite on cheyenne on 3 compilers as well as the full test suite on cheyenne with the gnu compiler. Everything passes and is bit-for-bit. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#9e4d244d7feb6ad9d03cc488c34c1f22c4ea7612
The gx1 CORE forcing uses the LYq forcing option and the LYq option is being removed. Deprecated source code by adding temporary cpp (UNDEPRECATE_LYq). The code can be formally removed later. Removed the LYq documentation. Removed the set_nml file and removed one test case.
Closes #627.